Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Danish localization #7220

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Add Danish localization #7220

wants to merge 13 commits into from
+8,295 −0

Conversation

c960657
Copy link
Contributor

@c960657 c960657 commented Dec 20, 2024

Add translation for Danish (da).

Demo site: https://bsky.aggemam.dk

@c960657 c960657 mentioned this pull request Dec 20, 2024
Closed
@c960657 c960657 mentioned this pull request Dec 22, 2024
Merged
@pfrazee
Copy link
Collaborator

pfrazee commented Dec 31, 2024

Awesome, thank you @c960657 ! If you could get one other danish speaker to review this, I can get it merged!

simonschultz
simonschultz reviewed Jan 1, 2025
View reviewed changes
Copy link

@simonschultz simonschultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good !!!

jyskweb
jyskweb reviewed Jan 2, 2025
View reviewed changes
Copy link

@jyskweb jyskweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical error in line messages.po#L8266

jyskweb
jyskweb reviewed Jan 2, 2025
View reviewed changes
Copy link

@jyskweb jyskweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error in navbar.

Screenshot_20250102_014704_Firefox

auroursa
auroursa reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@auroursa auroursa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this causing the navbar issue.

src/locale/locales/da/messages.po Outdated Show resolved Hide resolved
@c960657
Copy link
Contributor Author

c960657 commented Jan 2, 2025

Thanks for the reviews. The stray quote in the navbar and the error in line 8266 have been fixed now.

@c960657
Copy link
Contributor Author

c960657 commented Jan 2, 2025 •
edited
Loading

There is a suggestion here about translating “post” to “indlæg” or “opslag” (instead of just using the English term) and “repost” to “videredel”/“videredeling”. I tend to agree.

https://bsky.aggemam.dk/profile/esben.leonhard-frederiksen.dk/post/3leqwinep6224

jyskweb
jyskweb reviewed Jan 2, 2025
View reviewed changes
Copy link

@jyskweb jyskweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

surfdude29
surfdude29 reviewed Jan 2, 2025
View reviewed changes
lingui.config.js Outdated Show resolved Hide resolved
@surfdude29

This comment was marked as resolved.

Sign in to view
@kseistrup
Copy link

I've corrected a few typos. Please see attached diff:

📎 rettelser-diff.txt

Looks good otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surfdude29 surfdude29 surfdude29 left review comments

@auroursa auroursa auroursa left review comments

@jyskweb jyskweb jyskweb left review comments

@simonschultz simonschultz simonschultz left review comments

@renejsum renejsum renejsum left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@c960657 @pfrazee @surfdude29 @kseistrup @renejsum @simonschultz @jyskweb @auroursa